RFR: 8323511: Scrollbar Click jumps inconsistent amount of pixels [v9]
Johan Vos
jvos at openjdk.org
Fri May 24 12:37:20 UTC 2024
On Wed, 22 May 2024 15:50:46 GMT, Florian Kirmaier <fkirmaier at openjdk.org> wrote:
>> As seen in the unit test of the PR, when we click on the area above/below the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In the other cases, the assumed default cell height is used.
>>
>> With this PR, always the default cell height is used, to determine how much is scrolled.
>> This makes the behavior more consistent.
>>
>> Especially from the unit-test, it's clear that with this PR the behavior is much more consistent.
>>
>> This is also related to the following PR: https://github.com/openjdk/jfx/pull/1194
>
> Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision:
>
> JDK-8323511: Adjust javadoc of VirtualFlow.getViewportLength()
Marked as reviewed by jvos (Reviewer).
-------------
PR Review: https://git.openjdk.org/jfx/pull/1326#pullrequestreview-2076803074
More information about the openjfx-dev
mailing list