RFR: 8311895: CSS Transitions [v2]

Nir Lisker nlisker at openjdk.org
Sat May 25 19:42:11 UTC 2024


On Mon, 31 Jul 2023 18:10:46 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> modules/javafx.graphics/src/main/java/javafx/animation/Interpolator.java line 319:
>> 
>>> 317:      * The output time value is determined by the {@link StepPosition}.
>>> 318:      *
>>> 319:      * @param intervals the number of intervals in the step interpolator
>> 
>> minor: When I see a plural like `intervals` (or `employees`) I think of a list of objects. Perhaps `intervalCount` would be better?
>
> Doesn't sound better to me, but I'll defer to what most people feel is best.

I somewhat agree with John. I would probably just use `numberOfIntervals`, but `intervalCount` of `numIntervals` is also fine.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/870#discussion_r1614560326


More information about the openjfx-dev mailing list