RFR: 8311895: CSS Transitions [v17]

[Michael Strauß]

On Sat, 25 May 2024 19:35:56 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> Michael Strauß has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 57 commits:
>> 
>>  - Merge branch 'refs/heads/master' into feature/css-transitions
>>  - extract magic string to named constant
>>  - use existing property in test
>>  - fixed documentation
>>  - Merge branch 'master' into feature/css-transitions
>>  - update 'since' tags
>>  - Fix javadoc error
>>  - Change javadoc comment
>>  - Merge branch 'master' into feature/css-transitions
>>  - Discard redundant transitions in StyleableProperty impls
>>  - ... and 47 more: https://git.openjdk.org/jfx/compare/94aa2b68...a43dee30
>
> modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html line 690:
> 
>> 688:         changed, it smoothly transitions to the new value over a period of time. Implicit transitions are supported
>> 689:         for all primitive types, as well as for types that implement <code>javafx.animation.Interpolatable</code>.</p>
>> 690:     <p>Transitions can be defined for any node in the JavaFX scene graph with the following properties:</p>
> 
> The way this is phrased makes it sound like the node has "the following properties", not the transition. Maybe move that part:
> "Transitions with the following properties can be defined for any node in the JavaFX scene graph", or just add a comma.

I understand that you're saying that `property`, `duration`, `timing-function`, and `delay` are all sub-properties of `transition`.

However, from a CSS perspective, `transition-property`, `transition-duration`, `transition-timing-function` and `transition-delay` are properties of `Node`, in the same way as `-fx-background-color`, `-fx-background-insets`, etc. are properties of `Node`.

`transition` is a short-hand property that combines all four properties into one (we don't have a short-hand property for backgrounds yet). I think that both mental models are basically correct (four properties of node, vs. four sub-properties of transition).

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/870#discussion_r1614886767