RFR: 8326619: Stage.sizeToScene() on maximized/fullscreen Stage breaks the Window [v6]

Marius Hanl mhanl at openjdk.org
Mon May 27 19:37:19 UTC 2024


> This PR fixes the problem that maximizing/fullscreen a `Stage` or `Dialog` is broken when `sizeToScene()` was called before or after.
> 
> The approach here is to ignore the `sizeToScene()` request when the `Stage` is maximized or set to fullscreen. 
> Otherwise the Window Manager of the OS will be confused and you will get weird flickering or wrong Window buttons (e.g. on Windows, the 'Maximize' button still shows the 'Restore' Icon, while we already resized the `Stage` to not be maximized).

Marius Hanl has updated the pull request incrementally with one additional commit since the last revision:

  Make tests more robust, especially for MacOS

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1382/files
  - new: https://git.openjdk.org/jfx/pull/1382/files/e9b49d47..1d54e15f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1382&range=05
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1382&range=04-05

  Stats: 13 lines in 1 file changed: 6 ins; 2 del; 5 mod
  Patch: https://git.openjdk.org/jfx/pull/1382.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1382/head:pull/1382

PR: https://git.openjdk.org/jfx/pull/1382


More information about the openjfx-dev mailing list