RFR: 8296387: [Tooltip, CSS] -fx-show-delay is only applied to the first tooltip that is shown before it is displayed [v6]

Andy Goryachev angorya at openjdk.org
Tue May 28 16:51:13 UTC 2024


On Sun, 26 May 2024 13:02:23 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

>> This PR fixes a long standing issue where the `Tooltip` will always wait one second until it appears the very first time, even if the 
>> `-fx-show-delay` was set to another value.
>> 
>> The culprit is, that the `cssForced` flag is not inside `Tooltip`, but inside the `TooltipBehaviour`. So the very first `Tooltip` gets processed correctly, but after no `Tooltip` will be processed by CSS before showing, resulting in the set `-fx-show-delay` to not be applied immediately.
>> 
>> Added a bunch of headful tests for the behaviour since there were none before.
>
> Marius Hanl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add a test for changing the stylesheet and always process CSS for that matter

tests/system/src/test/java/test/robot/javafx/scene/TooltipTest.java line 134:

> 132: 
> 133:     @Test
> 134:     void testSmallShowDelayTooltip() {

what is the reason for removing 'public' keyword?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1394#discussion_r1617617930


More information about the openjfx-dev mailing list