RFR: 8342456: Remove calls to doPrivileged in javafx.graphics/other [v2]
Lukasz Kostyra
lkostyra at openjdk.org
Fri Nov 1 09:37:20 UTC 2024
On Thu, 31 Oct 2024 23:14:56 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> well, the original code is just sloppy, but we have a policy of not fixing unrelated issues, or even adding comments pointing out the sloppy code.
>>
>> in this case, we can probably ignore it - it's probably not worth fixing since it's a debug output.
>
> In this case, I wouldn't mind adding a comment about further follow-up, although I question whether it is worth it. Probably not (so you could just leave it alone).
> I have a separate question: Is the finally statement really needed?
Not really, I think I just repeated the pattern from other similar blocks. I'll remove it.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1619#discussion_r1825617862
More information about the openjfx-dev
mailing list