RFR: 8301121: RichTextArea Control (Incubator) [v35]

Andy Goryachev angorya at openjdk.org
Fri Nov 1 22:47:37 UTC 2024


On Fri, 1 Nov 2024 20:58:54 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   input map
>
> modules/jfx.incubator.richtext/src/main/java/com/sun/jfx/incubator/scene/control/richtext/Params.java line 102:
> 
>> 100: 
>> 101:     /** default preferred height */
>> 102:     public static final double PREF_HEIGHT = 176; // matches TextArea
> 
> I see `181` as TextArea height, at least on Windows. I think it is computed from the default number of columns visible. I didn't check on macOS.

it is not the goal to match the `TextArea`, especially if the latter is different on different platforms.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1826353095


More information about the openjfx-dev mailing list