RFR: 8301121: RichTextArea Control (Incubator) [v35]

[Andy Goryachev]

On Fri, 1 Nov 2024 18:42:45 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   input map
>
> modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/model/BasicTextModel.java line 68:
> 
>> 66:         /**
>> 67:          * This method is called to insert a single text segment at the given position.
>> 68:          * The caller guarantees that this method is only called when the content is writable.
> 
> Since this is a public method that could be called by an application, I think you still need to describe what happens if the caller does call when not writable.

the implementor of the `Content` can do whatever they want - I don't think we should specify that.  In this case, I think it's important to mention that the caller (the `BasicTextModel`) will never do.

maybe `caller` -> `BasicTextModel`

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1826361933