RFR: 8313424: JavaFX controls in the title bar [v19]

Michael Strauß mstrauss at openjdk.org
Tue Nov 5 06:10:39 UTC 2024


On Tue, 5 Nov 2024 00:09:59 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Michael Strauß has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 23 commits:
>> 
>>  - Merge branch 'master' into feature/extended-window
>>  - Merge branch 'master' into feature/extended-window
>>  - macOS: dynamically adapt toolbar style to headerbar height
>>  - fix header bar height flicker
>>  - NPE
>>  - fix peer access outside of synchronizer
>>  - improve title text documentation
>>  - macOS: hide window title
>>  - better documentation
>>  - set minHeight to native height of title bar
>>  - ... and 13 more: https://git.openjdk.org/jfx/compare/58cd76a8...9b63892d
>
> modules/javafx.graphics/src/main/java/javafx/scene/layout/HeaderBar.java line 59:
> 
>> 57:  * {@code HeaderBar} honors the minimum, preferred, and maximum sizes of its children. If the child's
>> 58:  * resizable range prevents it from be resized to fit within its position, it will be vertically centered
>> 59:  * relative to the available space; this alignment can be customized with a layout constraint.
> 
> what if the components are too large to fit, will clipping occur?  should this behavior be mentioned?

The components can't be too large to fit:
`{@code HeaderBar} honors the minimum, preferred, and maximum sizes of its children.`

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1828778020


More information about the openjfx-dev mailing list