RFR: 8342914: Remove calls to doPrivileged in swt [v2]

[Jayathirth D V]

On Wed, 30 Oct 2024 18:16:26 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Removes doPrivileged in the following module:
>> 
>> - javafx.swt
>> 
>> See JDK-8342441 for details.
>> 
>> As a helpful hint for reviewers, I recommend reviewing this using the "Hide whitespace" option.
>
> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - review comments
>  - Merge remote-tracking branch 'origin/master' into 8342914.do.privileged.swt
>  - Merge remote-tracking branch 'origin/master' into 8342914.do.privileged.swt
>  - 8342914: Remove calls to doPrivileged in swt

Change looks good to me.

modules/javafx.swt/src/main/java/javafx/embed/swt/FXCanvas.java line 84:

> 82: import org.eclipse.swt.widgets.Listener;
> 83: import org.eclipse.swt.widgets.Shell;
> 84: import com.sun.glass.ui.Application;

We were planning to not re-order imports as part of this exercise as it just adds more information to the PR.

Since this PR has less files it is fine.

-------------

Marked as reviewed by jdv (Author).

PR Review: https://git.openjdk.org/jfx/pull/1611#pullrequestreview-2414733970
PR Review Comment: https://git.openjdk.org/jfx/pull/1611#discussion_r1828800524