RFR: 8342460: Remove calls to doPrivileged in javafx.web [v2]
Ambarish Rapte
arapte at openjdk.org
Tue Nov 5 07:46:35 UTC 2024
On Fri, 1 Nov 2024 15:01:10 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> Removes `doPrivileged` calls in the javafx.web module, excluding the code in `{android,ios}`.
>
> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>
> review comments
LGTM, with one minor comment. Please take a look.
modules/javafx.web/src/main/java/javafx/scene/web/WebEngine.java line 1582:
> 1580: webEngine.debugger.messageCallback;
> 1581: if (messageCallback != null) {
> 1582: messageCallback.call(message);
@SuppressWarnings("removal") can be removed from this method.
-------------
Changes requested by arapte (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/1620#pullrequestreview-2414747585
PR Review Comment: https://git.openjdk.org/jfx/pull/1620#discussion_r1828809646
More information about the openjfx-dev
mailing list