RFR: 8313424: JavaFX controls in the title bar [v19]

Andy Goryachev angorya at openjdk.org
Tue Nov 5 16:06:39 UTC 2024


On Tue, 5 Nov 2024 01:13:39 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> modules/javafx.graphics/src/main/java/com/sun/glass/ui/WindowControlsOverlay.java line 199:
>> 
>>> 197:      */
>>> 198:     private final StyleableBooleanProperty allowRtl =
>>> 199:         new SimpleStyleableBooleanProperty(ALLOW_RTL_METADATA, this, "allowRtl", true) {
>> 
>> why is `allowRtl` a property and not a simple flag?
>> why is it allowed to be changed via CSS via `-fx-allow-rtl`?
>
> The purpose is to allow JavaFX developers (that is us, not users of JavaFX) to define the entire appearance of `WindowControlsOverlay` with a CSS file. This should make it easier to maintain it, since we won't have to keep looking in two places to change the appearance.

I don't understand: why the orientation of EXTENDED window be different from that of the platform (unless explicitly configured with Scene.nodeOrientation)?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1829620861


More information about the openjfx-dev mailing list