RFR: 8313424: JavaFX controls in the title bar [v19]

Michael Strauß mstrauss at openjdk.org
Tue Nov 5 16:24:37 UTC 2024


On Tue, 5 Nov 2024 16:09:24 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Yes, but if we do that, then we should do it everywhere it matters. The native toolkits are not multi-threaded, so all native upcalls happen on the JavaFX application thread. We should probably do this in another PR, and discuss how to do it uniformly (javadoc, annotation, etc).
>
> I think it would make sense to start doing this in the new code, as this helps to show the connection.  Only if as a courtesy to the developers who have to read the code years later.

Maybe so, but let's not discuss this in this PR. It's probably best to have a discussion on the mailing list first, and come up with a consistent way of documenting native upcalls.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1829649238


More information about the openjfx-dev mailing list