RFR: 8313424: JavaFX controls in the title bar [v21]
Michael Strauß
mstrauss at openjdk.org
Tue Nov 5 20:37:35 UTC 2024
On Tue, 5 Nov 2024 16:36:26 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>>
>> stylistic changes
>
> modules/javafx.graphics/src/main/java/javafx/scene/layout/HeaderBar.java line 170:
>
>> 168: // Inflate the minHeight property. This is important so that we can track whether a stylesheet or
>> 169: // user code changes the property value before we set it to the height of the native title bar.
>> 170: minHeightProperty();
>
> if that's the case, why not initialize it in L1150 ?
Where? The file only has about 500 lines.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1829965296
More information about the openjfx-dev
mailing list