RFR: 8313424: JavaFX controls in the title bar [v21]

Michael Strauß mstrauss at openjdk.org
Tue Nov 5 21:51:39 UTC 2024


On Tue, 5 Nov 2024 16:37:48 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   stylistic changes
>
> modules/javafx.graphics/src/main/java/javafx/scene/layout/HeaderBar.java line 262:
> 
>> 260:     @Override
>> 261:     protected double computeMinWidth(double height) {
>> 262:         Node leading = getLeading(), center = getCenter(), trailing = getTrailing();
> 
> I think it's a bad practice to have multiple statements on one line.

Changed.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1830045964


More information about the openjfx-dev mailing list