RFR: 8313424: JavaFX controls in the title bar [v22]
Andy Goryachev
angorya at openjdk.org
Tue Nov 5 23:03:36 UTC 2024
On Tue, 5 Nov 2024 21:31:56 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:
>> Implementation of [`EXTENDED` stage style](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
>
> Michael Strauß has updated the pull request incrementally with three additional commits since the last revision:
>
> - HeaderBar changes
> - EMPTY Dimension2D constant
> - use CsvSource in HeaderBarTest
modules/javafx.graphics/src/test/java/test/javafx/scene/layout/HeaderBarTest.java line 237:
> 235: "BOTTOM_RIGHT, 740, 40, 100, 50"
> 236: })
> 237: void alignmentOfCenterChild_notResizable_withNonEmptyLeadingAndTrailingChild(
minor suggestion:
long test names do not help much (and actually may cause problems, see https://bugs.openjdk.org/browse/JDK-8334497)
also rather inconvenient to see in the logs, or IDEs. You can use comments for human-readability and short(er) method names.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1830157870
More information about the openjfx-dev
mailing list