RFR: 8301121: RichTextArea Control (Incubator) [v37]

[Andy Goryachev]

On Wed, 6 Nov 2024 11:03:50 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 52 commits:
>> 
>>  - readme
>>  - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea
>>  - review comments
>>  - input map
>>  - validate model
>>  - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea
>>  - javadoc
>>  - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea
>>  - review comments
>>  - measurement node
>>  - ... and 42 more: https://git.openjdk.org/jfx/compare/bd4bc057...a51ae151
>
> modules/jfx.incubator.input/src/main/java/com/sun/jfx/incubator/scene/control/input/KeyEventMapper.java line 39:
> 
>> 37:     private static final int TYPED = 0x04;
>> 38: 
>> 39:     private int types;
> 
> I think, the 3 event types are mutually exclusive, either a key would be pressed or released or typed.
> so the name of this variable should be a singular form `type` or preferably `eventType`

all these are private fields of an internal implementation

> modules/jfx.incubator.input/src/main/java/com/sun/jfx/incubator/scene/control/input/KeyEventMapper.java line 42:
> 
>> 40: 
>> 41:     public KeyEventMapper() {
>> 42:     }
> 
> May be remove empty default ctor.

why?  this class is not exposed.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1831825819
PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1831826424