RFR: 8313424: JavaFX controls in the title bar [v19]
Michael Strauß
mstrauss at openjdk.org
Thu Nov 7 03:09:52 UTC 2024
On Mon, 4 Nov 2024 23:01:03 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> Michael Strauß has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 23 commits:
>>
>> - Merge branch 'master' into feature/extended-window
>> - Merge branch 'master' into feature/extended-window
>> - macOS: dynamically adapt toolbar style to headerbar height
>> - fix header bar height flicker
>> - NPE
>> - fix peer access outside of synchronizer
>> - improve title text documentation
>> - macOS: hide window title
>> - better documentation
>> - set minHeight to native height of title bar
>> - ... and 13 more: https://git.openjdk.org/jfx/compare/58cd76a8...9b63892d
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/WindowControlsOverlay.java line 74:
>
>> 72: * <li>{@link Region} — {@code window-button}, {@code maximize-button}
>> 73: * <li>{@link Region} — {@code window-button}, {@code close-button}
>> 74: * </ul>
>
> 1. I think this part (css ref) is rather important and maybe should be a part of this PR. It would be nice to be able to review the CSS reference as a part of this PR.
> 2. if you don't kind, could you please link your JEP to the PR and the ticket?
> 3. could you please include the "application title" row in the table in the JEP?
1. As already mentioned, the CSS is a blackbox implementation detail.
2. Done.
3. Done.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1831989442
More information about the openjfx-dev
mailing list