RFR: 8313424: JavaFX controls in the title bar [v21]

Michael Strauß mstrauss at openjdk.org
Thu Nov 7 03:59:52 UTC 2024


On Tue, 5 Nov 2024 18:48:00 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   stylistic changes
>
> modules/javafx.graphics/src/main/java/javafx/scene/layout/HeaderBarBase.java line 190:
> 
>> 188:      * independent of layout orientation.
>> 189:      */
>> 190:     private final ReadOnlyObjectWrapper<Dimension2D> rightSystemInset =
> 
> Q: would it make sense to create a class with requestLayout() ?  this will save two class objects...

It'll only save one class (the other is not a `ReadOnlyObjectWrapper`). I'm probably leaving that as-is.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1832017038


More information about the openjfx-dev mailing list