RFR: 8313424: JavaFX controls in the title bar [v19]

[Andy Goryachev]

On Thu, 7 Nov 2024 03:25:41 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> I want to know what happens when the layout is over-constrained.  For example, consider the layout to have the leading, the center, and the trailing nodes set, and the leading one has minWidth set to 10_000.  What happens?
>> 
>> Will the center and the trailing nodes be shown or clipped?  will the layout attempt to squeeze all three to fit the available space?
>> 
>> Can I get this answer from the javadoc?
>
> I've added another sentence to the javadocs of `HeaderBar`:
> 
>  * All children will be resized to their preferred widths and extend the height of the {@code HeaderBar}.
>  * {@code HeaderBar} honors the minimum, preferred, and maximum sizes of its children. As a consequence,
>  * its computed minimum size is sufficient to accommodate all of its children.
> 
> 
> Does that help?

it is probably ok - I am curious what @kevinrushforth might think.

it might be either obvious that the window will cut off the HB if it is wider than the window width, or it should be explicitly mentioned (there is probably enough text to go through to kind of understand the behavior in the case of over-constrained HB, or the dev can just try it).

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1833038167