RFR: 8207759: VK_ENTER not consumed by TextField when default Button exists [v3]

[Andy Goryachev]

On Fri, 8 Nov 2024 12:48:45 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> Jeanette Winzenburg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   added tests to guard against JDK-8145515
>
> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TextFieldBehavior.java line 190:
> 
>> 188:         if (onAction != null || actionEvent.isConsumed()) {
>> 189:             event.consume();
>> 190:         }
> 
> @kleopatra @kevinrushforth @aghaisas 
> 
> Shouldn't this be an `&&` ?  Now having an empty `setOnAction` that doesn't consume anything (but just logs for example) will affect the operation of this control.

correct, it's a bug.
#1523

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/15#discussion_r1834587435