RFR: 8306707: Support pluggable image loading via javax.imageio [v11]

Michael Strauß mstrauss at openjdk.org
Wed Nov 13 06:21:03 UTC 2024


On Wed, 13 Nov 2024 04:38:51 GMT, Jayathirth D V <jdv at openjdk.org> wrote:

>> I'm just starting to look at this. The tests I ran look good so far, with two things to note:
>> 
>> 1. If `XImageLoaderFactory` fails to load, it with throw an `Error` that terminates the app. I left a comment and suggestion inline.
>> 2. This patch causes a failure in one of our closed white-box tests, which depends on internal API that has changed. It will be easy for us to fix it, but it will mean that down the road, when this is ready to go in, we will need to coordinate the timing of the integration with you.
>
>>     2. This patch causes a failure in one of our closed white-box tests, which depends on internal API that has changed. It will be easy for us to fix it, but it will mean that down the road, when this is ready to go in, we will need to coordinate the timing of the integration with you.
> 
> I think @mstr2 can use `/integrate delegate` Skara command as mentioned at https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/integrate. So that @kevinrushforth can time this integration in future.

@jayathirthrao @hjohn Please review the latest changes.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1593#issuecomment-2472533895


More information about the openjfx-dev mailing list