RFR: 8344067: TableCell indices may not match the TableRow index [v2]

Marius Hanl mhanl at openjdk.org
Wed Nov 13 20:02:02 UTC 2024


On Wed, 13 Nov 2024 18:10:49 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> modules/javafx.controls/src/test/java/test/javafx/scene/control/TableViewRowTest.java line 222:
>> 
>>> 220:         row.updateIndex(0);
>>> 221: 
>>> 222:         List<TableCell<String, String>> cells = row.getChildrenUnmodifiable().stream().
>> 
>> minor suggestion: maybe reformat to keep one statement per line
>> 
>> 
>> row.getChildrenUnmodifiable().stream().
>>    filter(TableCell.class::isInstance).
>>    map(e -> (TableCell<String, String>) e).
>>    toList();
>
> (here and elsewhere)

I usually keep it this way as it is still readable and less space. But changed the formatting so that the statement with the dot `.filter` is in the new line. This is as far as I know what most people do.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1635#discussion_r1841083038


More information about the openjfx-dev mailing list