RFR: 8309381: Support JavaFX incubator modules
Johan Vos
jvos at openjdk.org
Thu Nov 14 09:35:40 UTC 2024
On Tue, 29 Oct 2024 22:23:35 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
> This PR add the necessary support for [JavaFX Incubator Modules](https://github.com/kevinrushforth/jfx/blob/jfx.incubator/INCUBATOR-MODULES.md). It includes the following:
>
> 1. Changes to the build scripts `build.gradle` and `settings.gradle` to document where to add your incubator module. Also added `jlink` flags to not resolve incubator modules by default and warn when resolving (same as is done for JDK incubator modules).
> 2. A utility class to produce warnings when first using an incubator module.
> 3. Changes to `javafx.base/module-info.java` to document where to add the needed qualified exports to your module to access the utility class in 2.
>
> See PR #1617 for a sample module that is built on top of this PR's source branch.
>
> This is almost ready to review. I will take it out of Draft in the next day or so.
build.gradle line 4048:
> 4046: 'controls',
> 4047:
> 4048: // Add an entry for each incubator module here, leaving the incubator
Can we check for the existence of a file in e.g. buildSrc/incubator.gradle instead, and if so, modify things like dependendProjects in that file?
The build.gradle is already huge and hard to understand/maintain. Every line we add to it makes it harder.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1616#discussion_r1841860992
More information about the openjfx-dev
mailing list