RFR: 8309381: Support JavaFX incubator modules

[Kevin Rushforth]

On Thu, 14 Nov 2024 09:32:33 GMT, Johan Vos <jvos at openjdk.org> wrote:

>> This PR add the necessary support for [JavaFX Incubator Modules](https://github.com/kevinrushforth/jfx/blob/jfx.incubator/INCUBATOR-MODULES.md). It includes the following:
>> 
>> 1. Changes to the build scripts `build.gradle` and `settings.gradle` to document where to add your incubator module. Also added `jlink` flags to not resolve incubator modules by default and warn when resolving (same as is done for JDK incubator modules).
>> 2. A utility class to produce warnings when first using an incubator module.
>> 3. Changes to `javafx.base/module-info.java` to document where to add the needed qualified exports to your module to access the utility class in 2.
>> 
>> See PR #1617 for a sample module that is built on top of this PR's source branch.
>> 
>> This is almost ready to review. I will take it out of Draft in the next day or so.
>
> build.gradle line 4048:
> 
>> 4046:         'controls',
>> 4047: 
>> 4048:         // Add an entry for each incubator module here, leaving the incubator
> 
> Can we check for the existence of a file in e.g. buildSrc/incubator.gradle instead, and if so, modify things like dependendProjects in that file?
> The build.gradle is already huge and hard to understand/maintain. Every line we add to it makes it harder.

That's an interesting idea. I'll prototype it and see how it looks.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1616#discussion_r1842130558