RFR: 8313424: JavaFX controls in the title bar [v27]

[Michael Strauß]

On Thu, 14 Nov 2024 15:53:50 GMT, Martin Fox <mfox at openjdk.org> wrote:

>> Michael Strauß has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 34 commits:
>> 
>>  - Merge branch 'master' into feature/extended-window
>>  - Merge branch 'master' into feature/extended-window
>>  - add system menu documentation
>>  - WindowControlsOverlay snapping
>>  - HeaderBar javadoc change
>>  - refactor performWindowDrag
>>  - HeaderBar changes
>>  - EMPTY Dimension2D constant
>>  - use CsvSource in HeaderBarTest
>>  - stylistic changes
>>  - ... and 24 more: https://git.openjdk.org/jfx/compare/d0011b21...65f095ef
>
> modules/javafx.graphics/src/main/native-glass/mac/GlassWindow.m line 1542:
> 
>> 1540:     GLASS_POOL_ENTER;
>> 1541:     {
>> 1542:         NSString* preferredLanguage = [[NSLocale preferredLanguages] objectAtIndex:0];
> 
> Is there some reason you're not using the `NSWindow.windowTitlebarLayoutDirection` property?

It just doesn't seem to work. `NSWindow.windowTitlebarLayoutDirection` always returns `NSUserInterfaceLayoutDirectionLeftToRight`, even when my system layout direction clearly is right-to-left. I haven't been able to find out why that is.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1842663820