RFR: 8313424: JavaFX controls in the title bar [v29]
Michael Strauß
mstrauss at openjdk.org
Thu Nov 14 19:02:26 UTC 2024
On Thu, 14 Nov 2024 18:19:14 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>>
>> macOS: double-click action + fullscreen toolbar
>
> modules/javafx.graphics/src/test/addExports line 59:
>
>> 57: --add-opens javafx.graphics/javafx.scene.paint=ALL-UNNAMED
>> 58: --add-opens javafx.graphics/javafx.stage=ALL-UNNAMED
>> 59: --add-opens java.desktop/javax.imageio=ALL-UNNAMED
>
> this change seems unrelated
`WindowControlsOverlayTest.activePseudoClassCorrespondsToStageFocusedProperty()` requires `opens javafx.stage`.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1842749731
More information about the openjfx-dev
mailing list