RFR: 8342993: Remove uses of AccessController and AccessControlContext from JavaFX [v2]

[Andy Goryachev]

On Thu, 14 Nov 2024 23:45:51 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/Toolkit.java line 98:
>> 
>>> 96: 
>>> 97:     // Used as the (dummy) value for the various listener maps
>>> 98:     private static final Object dummyObj = new Object();
>> 
>> minor: maybe use all-uppercase name for this static final object?
>> 
>> we could also be using Boolean.TRUE (or null), since there is a comment down below explaining the purpose of these maps.
>> 
>> curiously, there is no WeakHashSet.
>
> There is no need for `WeakHashSet`, because it would be equivalent to `Collections.newSetFromMap(new WeakHashMap<>())`.
> `HashSet` already uses `HashMap` in its implementation.

wow, I did not they _cut corners_ there.  who is going to look after little peo^H^H^H bytes?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1638#discussion_r1843020897