RFR: 8343196: Add build property to identify experimental builds of JavaFX [v2]
Johan Vos
jvos at openjdk.org
Sat Nov 16 18:34:51 UTC 2024
On Sat, 16 Nov 2024 16:16:58 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
> > I might be confused, but wasn't the idea to use a new property (e.g. jfx.feature.variant) instead of overloading the existing jfx.release.suffix?
>
> This PR does add a new property in `build.properties`,`jfx.experimental.release.suffix`, and does not require modifying `jfx.release.suffix`. For example, in the "metal" branch of the jfx-sandbox, we would define this as:
>
> ```
> jfx.experimental.release.suffix=-metal
> ```
My apologies, I misread the proposed code.
It is a bit confusing to have "jfx.release.suffix" and "jfx.experimental.release.suffix" where the former refers to an artifact property and the latter refers to a major feature/variant/... like metal. But then, consistent naming is always difficult so I'm ok with the proposed suggestion.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1637#issuecomment-2480728513
More information about the openjfx-dev
mailing list