RFR: 8343196: Add build property to identify experimental builds of JavaFX [v3]
Ambarish Rapte
arapte at openjdk.org
Mon Nov 18 12:11:17 UTC 2024
On Mon, 18 Nov 2024 11:52:12 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:
>> Introduce a new build property `jfx.experimental.release.suffix` to be used for the early access builds of an under development feature in JavaFX.
>> This property would be set to a value ONLY in a branch specific to an experiment in [jfx-sandbox](https://github.com/openjdk/jfx-sandbox) repo.
>> For example:
>> For the metal branch in jfx-sandbox repo, it would be set to `-metal`. The javafx.version for the early access build generated from that branch would be `24-metal`.
>>
>> And it would always be empty for master branch in both main jfx repo and in jfx-sandbox repo.
>> This change has no effect on a regular developer build from master branch.
>
> Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision:
>
> review comments
Why we chose the name `jfx.experimental.release.suffix`.
The JavaFX version string contains the value of `jfx.release.suffix` i.e `-ea` as a suffix. The new variable would be doing same, so it is also a suffix.
`24-ea` would be now `24-metal`
and use of `experimental` is justified by @nlisker as:
> I would have went with jfx.experimental.name :) because the sandbox has experimental features, as opposed to other features that are directly integrated into the main stream.
`jfx.release.suffix` **:** JavaFX relase version suffix for early access releases i.e `-ea`
`jfx.experimental.release.suffix` **:** JavaFX relase version suffix for experimental releases.
With this understanding, I am happy with the current name :) but shall update the PR we finalize any other name.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1637#issuecomment-2482858940
More information about the openjfx-dev
mailing list