RFR: 8343196: Add build property to identify experimental builds of JavaFX [v5]

[Kevin Rushforth]

On Mon, 18 Nov 2024 20:56:44 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> Introduce a new build property `jfx.experimental.release.suffix` to be used for the early access builds of an under development feature in JavaFX.
>> This property would be set to a value ONLY in a branch specific to an experiment in [jfx-sandbox](https://github.com/openjdk/jfx-sandbox) repo.
>> For example:
>> For the metal branch in jfx-sandbox repo, it would be set to `-metal`.  The javafx.version for the early access build generated from that branch would be `24-metal`.
>> 
>> And it would always be empty for master branch in both main jfx repo and in jfx-sandbox repo.
>> This change has no effect on a regular developer build from master branch.
>
> Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision:
> 
>   correcttion

Looks good with one suggested change.

build.gradle line 706:

> 704:         relSuffix = jfxExperimentalFeatureName != "" ?
> 705:                         "-${jfxExperimentalFeatureName}" : jfxReleaseSuffix;
> 706:         relOpt = "-${buildTimestamp}"

This will unconditionally add a timestamp to _all_ EA builds of JavaFX, not just experimental builds. Changing the version string for EA builds seems out of scope for this PR.

Suggestion:

        if (jfxExperimentalFeatureName != "") {
            relSuffix = "-${jfxExperimentalFeatureName}"
            relOpt = "-${buildTimestamp}"
        } else {
            relSuffix = jfxReleaseSuffix
        }

-------------

PR Review: https://git.openjdk.org/jfx/pull/1637#pullrequestreview-2443738897
PR Review Comment: https://git.openjdk.org/jfx/pull/1637#discussion_r1847283536