RFR: 8301121: RichTextArea Control (Incubator) [v47]

Andy Goryachev angorya at openjdk.org
Thu Nov 21 21:02:30 UTC 2024


On Thu, 21 Nov 2024 00:02:17 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 66 commits:
>> 
>>  - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea
>>  - hide skin input map
>>  - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea
>>  - whitespace
>>  - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea
>>  - save as
>>  - removed function handler
>>  - removed add handler last
>>  - use focus traversal api
>>  - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea
>>  - ... and 56 more: https://git.openjdk.org/jfx/compare/3a8a5598...e45be7b7
>
> modules/jfx.incubator.input/src/main/java/jfx/incubator/scene/control/input/KeyBinding.java line 343:
> 
>> 341:     /**
>> 342:      * Creates a {@link Builder} with the specified KeyCode.
>> 343:      * @param character the character
> 
> Since the type is String what if it is more than one character?

Good point.  Added a link to `KeyEvent.getCharacter()`

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1852893089


More information about the openjfx-dev mailing list