RFR: 8309381: Support JavaFX incubator modules [v2]
Andy Goryachev
angorya at openjdk.org
Fri Nov 22 20:00:22 UTC 2024
On Tue, 5 Nov 2024 22:38:52 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> Kevin Rushforth has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>>
>> - Merge branch 'master' into 8309381-incubator.dev
>> - Remove call to doPrivileged
>> - 8309381: Support JavaFX incubator modules
>
> looks consistent with the original changes, but easier to understand.
>
> had a few minor suggestions, will re-approve if you decide to fix it (WRAIYDTFI).
> @andy-goryachev-oracle Can you take a look?
could you create a draft PR for v2, so we can leave comments?
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1616#issuecomment-2494693909
More information about the openjfx-dev
mailing list