RFR: 8342233: Regression: TextInputControl selection is backwards in RTL mode
Andy Goryachev
angorya at openjdk.org
Fri Nov 22 23:59:29 UTC 2024
A fix for [JDK-8319844](https://bugs.openjdk.org/browse/JDK-8319844) Text/TextFlow.hitTest() introduced a regression in the `TextArea`/`TextField`/`PasswordField` in the RTL mode.
The fix is to flip the x coordinates when needed in the `TextAreaSkin`/`TextFieldSkin`.
The RTL node orientation also breaks navigation using keyboard arrow keys, but that's a different issue: [JDK-8296266](https://bugs.openjdk.org/browse/JDK-8296266).
---
I tried to devise a headful test, but it is currently blocked by [JDK-8189167](https://bugs.openjdk.org/browse/JDK-8189167)
The fix can be tested manually using the Monkey Tester, with the headful test to be added probably as a part of [JDK-8326869](https://bugs.openjdk.org/browse/JDK-8326869) .
-------------
Commit messages:
- linux
- take a screenshot
- test
- review comments
- Merge remote-tracking branch 'origin/master' into ag.rtl.regression
- whitespace
- test
- cleanup
- Merge remote-tracking branch 'origin/master' into ag.rtl.regression.2
- Merge remote-tracking branch 'origin/8342462.text.area.skin.cleanup' into ag.rtl.regression.2
- ... and 6 more: https://git.openjdk.org/jfx/compare/3a8a5598...a4f295a3
Changes: https://git.openjdk.org/jfx/pull/1609/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1609&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8342233
Stats: 610 lines in 8 files changed: 559 ins; 23 del; 28 mod
Patch: https://git.openjdk.org/jfx/pull/1609.diff
Fetch: git fetch https://git.openjdk.org/jfx.git pull/1609/head:pull/1609
PR: https://git.openjdk.org/jfx/pull/1609
More information about the openjfx-dev
mailing list