RFR: 8309381: Support JavaFX incubator modules [v2]

[Kevin Rushforth]

On Sat, 23 Nov 2024 02:10:21 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> Kevin Rushforth has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Merge branch 'master' into 8309381-incubator.dev
>>  - Remove call to doPrivileged
>>  - 8309381: Support JavaFX incubator modules
>
> I had a look (at v2). If this approach works then it's fine for now, but it repeats the sin of coupling configurations of (potentially) unrelated modules and will increase the build time for a normal build (at least it will from the looks of it). It can be fix as part of the cleanup, but I don't see an easy way to make it work "properly" with the current setup.

@nlisker @johanvos @andy-goryachev-oracle Thanks for taking a look. On further reflection, I prefer to stick with the version in _this_ PR, rather than doing something ad hoc for just the incubator modules (Andy recommended the same in [this comment on Draft PR v2](https://github.com/openjdk/jfx/pull/1646#pullrequestreview-2455643214)).

So I propose to integrate this PR "as is", and file a follow-up bug for further improvements, linking it to the overall Gradle modernization umbrella Task, [JDK-8344728](https://bugs.openjdk.org/browse/JDK-8344728).

I'll wait until at least Tuesday of next week to see if there are additional comments.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1616#issuecomment-2495543060