RFR: 8344906: Simplify Java version parsing in the build file [v2]

Ambarish Rapte arapte at openjdk.org
Wed Nov 27 13:29:47 UTC 2024


On Wed, 27 Nov 2024 10:35:18 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> Replaces the manual versions handling with [Version](https://docs.oracle.com/en/java/javase/23/docs/api/java.base/java/lang/Runtime.Version.html).
>> 
>> Changes:
>> * Removed the methods `parseJavaVersion(String)`, `parseJdkVersion(String)` and `compareJdkVersion(String, String)`, and replaced them with `Version.parse` and `Version.compareTo` methods.
>> * Removed the build properties of the Java version on which the Gradle build runs because they are only used for logging. Replaced with logging them directly. Note that Gradle logs by itself the info of the runtime it uses, so there's no need to logs these manually.
>> * Simplified the build JDK version by working directly with `Version` instead of a `String`. This allows to store less build properties. Also used try-with-resources to close the stream. Note that the whole build JDK manual invocation hack should be replaced with the Java Toolchain.
>> * Simplified the `verifyJava` task, which could also be replaced with built-in Gradle tools.
>
> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add missing :

Marked as reviewed by arapte (Reviewer).

-------------

PR Review: https://git.openjdk.org/jfx/pull/1647#pullrequestreview-2465026942


More information about the openjfx-dev mailing list