RFR: 8341372: BackgroundPosition, BorderImage, BorderStroke, CornerRadii should be final [v2]
John Hendrikx
jhendrikx at openjdk.org
Mon Oct 7 15:10:43 UTC 2024
On Wed, 2 Oct 2024 17:53:15 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:
>> Backgrounds and borders are comprised of immutable and final types. The following types are marked with the `final` modifier:
>>
>> * Background
>> * BackgroundFill
>> * BackgroundImage
>> * BackgroundSize
>> * Border
>> * BorderWidths
>>
>> The following types are not marked with the `final` modifier:
>>
>> * BackgroundPosition
>> * BorderImage
>> * BorderStroke
>> * CornerRadii
>>
>> This is probably just an oversight, as there is no value in allowing a subsection of these types to be extended.
>
> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>
> make fields private
Changes look good; those classes should definitely be final.
-------------
Marked as reviewed by jhendrikx (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/1587#pullrequestreview-2352222378
More information about the openjfx-dev
mailing list