RFR: 8339603: Seal the class hierarchy of Node, Camera, LightBase, Shape, Shape3D [v3]

Michael Strauß mstrauss at openjdk.org
Tue Oct 8 15:03:48 UTC 2024


On Tue, 8 Oct 2024 14:55:48 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> maybe an explanatory comment should be added?
>
> We typically use `InternalError` for the case where there should be no possible reason for a particular case, but also use `AssertionError` in some cases. Either is OK with me. I agree that a comment to the affect of "Should not ever get here" wouldn't be a bad idea.

I've added a comment to `CameraHelper` and `LightBaseHelper`.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1556#discussion_r1792050933


More information about the openjfx-dev mailing list