RFR: 8341090: Remove support for security manager from JavaFX

Kevin Rushforth kcr at openjdk.org
Wed Oct 9 17:55:02 UTC 2024


On Wed, 9 Oct 2024 17:26:16 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> It's related. See this comment in the PR Description:
>> 
>>> ...as part of this, I renamed`CustomSecurityManagerTest` to `StageRobotTest` and removed all of the tests that depend on the security manager, since the test methods that don't depend on SM are useful functional tests of a Stage's FullScreen and AlwaysOnTop mode.
>> 
>> Because I ended up deleting so much of the file, git's heuristic for detecting renames doesn't think that it is.
>> 
>> If you run this diff manually on the PR branch, you'll see it:
>> 
>> 
>> git diff --find-renames=40 master... -- tests/system/src/test/java/test/robot/helloworld
>
> sorry, missed that.  please ignore the comment.

git doesn't make it easy in cases like this, since it doesn't track renames at all (it provides the illusion of tracking renames via it's diff-time heuristic).

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1595#discussion_r1793930324


More information about the openjfx-dev mailing list