RFR: 8341514: Add reducedMotion and reducedTransparency preferences [v4]

Michael Strauß mstrauss at openjdk.org
Wed Oct 9 18:14:06 UTC 2024


On Wed, 9 Oct 2024 17:29:10 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix deferred property notification
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/application/preferences/PreferenceProperties.java line 199:
> 
>> 197:          */
>> 198:         @SuppressWarnings("unchecked")
>> 199:         public void setPlatformValue(Object value) {
> 
> should this method be declared package protected?

It doesn't really matter, since it's a nested class. The outer class has access to all members, regardless of visibility. Sometimes I use access modifiers in nested classes to informally document intent (which methods are supposed to be called by the outer class, and which are not). For consistency, I've added the `public` modifier to `fireValueChangeIfNecessary`.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1592#discussion_r1793952334


More information about the openjfx-dev mailing list