RFR: 8090456: Focus Management [v8]
Martin Fox
mfox at openjdk.org
Wed Oct 9 20:04:24 UTC 2024
On Wed, 2 Oct 2024 17:33:15 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> Public APIs for focus traversal and the focus traversal policy:
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal.md
>>
>> This work is loosely based on the patch
>> https://cr.openjdk.org/~jgiles/8061673/
>
> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits:
>
> - Merge remote-tracking branch 'origin/master' into 8090456.focus.traversal
> - removed traversal event
> - javadoc
> - remove bounds
> - whitespace
> - Merge remote-tracking branch 'origin/master' into 8090456.focus.traversal
> - Merge remote-tracking branch 'origin/master' into 8090456.focus.traversal
> - review comments
> - Merge remote-tracking branch 'origin/master' into 8090456.focus.traversal
> - review comments part 1
> - ... and 4 more: https://git.openjdk.org/jfx/compare/4d3c3661...9e1fa796
FWIW I have no issue with these as static methods. You're asking the traversal engine to move the focus and supplying a starting node. The traversal engine is the only actor here; the node is just a bystander. It might be clearer if the name was `FocusTraversal.traverseLeftFrom(Node node)` though that's a matter of style (I'm not asking for any changes.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1555#issuecomment-2403328755
More information about the openjfx-dev
mailing list