RFR: 8341440: ScrollPane: no immediate effect changing fitWidth/fitHeight

Andy Goryachev angorya at openjdk.org
Thu Oct 10 23:25:13 UTC 2024


On Thu, 10 Oct 2024 22:58:23 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> modules/javafx.controls/src/main/java/javafx/scene/control/ScrollPane.java line 358:
>> 
>>> 356:      * contained node is not a Resizable, this value is ignored.
>>> 357:      *
>>> 358:      * @defaultValue false
>> 
>> This is unrelated to the fix, and you were otherwise not touching this file. Why change it?
>
> it is related to the fix, may be we differ in the _degree_ of relation.  I did not want to create a separate ticket for such a minor clarification...  but maybe I should, and fix all the missing `@defaultValue`s across the controls.

Filed https://bugs.openjdk.org/browse/JDK-8341925

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1597#discussion_r1796213056


More information about the openjfx-dev mailing list