RFR: 8341440: ScrollPane: no immediate effect changing fitWidth/fitHeight [v2]

John Hendrikx jhendrikx at openjdk.org
Thu Oct 10 23:40:13 UTC 2024


On Thu, 10 Oct 2024 23:29:29 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> - fixed the issue
>> - added unit tests
>> - clarified default value of `ScrollPane.fitWidth` and `ScrollPane.fitHeight` properties
>> 
>> No CSR is needed as it is a minor clarification.
>
> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   you say unrelated, I say un-related

Looks okay.

minor: I think `viewContent.requestLayout()` should suffice.  But perhaps `ScrollPaneSkin` is doing more tricks.

-------------

Marked as reviewed by jhendrikx (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1597#pullrequestreview-2361616159


More information about the openjfx-dev mailing list