RFR: 8340005: Eliminate native access calls from javafx.swing

[Kevin Rushforth]

On Tue, 15 Oct 2024 17:03:09 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> modules/javafx.graphics/src/main/native-prism/SwingInterop.c line 31:
>> 
>>> 29:  * Class com_sun_javafx_application_PlatformImpl
>>> 30:  * Method: overrideNativeWindowHandle
>>> 31:  * Signature (Ljava/lang/Class;JLjava/lang/Runnable)Ljdk.swing.interop.LightweightFrameWrapper;
>> 
>> The signature should be changed to match the actual method. You can copy / paste from the generated header file.
>> 
>> Also, I recommend including the generated header file in this file (after the include of `jni.h`)
>
> was the header file omitted?  It did compile, could I have missed a warning?

The header file wasn't included prior to this change, which was an oversight. It will compile without it, although you will lose the error checking for mismatched signatures. It is a best practice to include it.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1600#discussion_r1801605127