RFR: 8340005: Eliminate native access calls from javafx.swing [v3]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Wed Oct 16 02:25:53 UTC 2024
> While implementing [JDK-8339517](https://bugs.openjdk.org/browse/JDK-8339517) to eliminate native access warnings by passing "--enable-native-access" for the three JavaFX modules with native code (javafx.graphics, javafx.media, and javafx.web), it was found that the Swing interop code in javafx.swing calls a JNI method defined in one of the native graphics libraries (prism-common) directly
>
> This means that even after [JDK-8339517](https://bugs.openjdk.org/browse/JDK-8339517) is fixed, we still get native access warnings when running any test that uses SwingNode.
>
> This fixes the native access warning by making javafx.graphics module call the native JNI and Swing-interop calls the static utility method in javafx.graphics, in this case defined in PlatformImpl
>
> All test.javafx.embed.swing SwingNode tests are running ok without any native warning
Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
Revert platformimpl change
-------------
Changes:
- all: https://git.openjdk.org/jfx/pull/1600/files
- new: https://git.openjdk.org/jfx/pull/1600/files/7d1f2707..19c355d7
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jfx&pr=1600&range=02
- incr: https://webrevs.openjdk.org/?repo=jfx&pr=1600&range=01-02
Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
Patch: https://git.openjdk.org/jfx/pull/1600.diff
Fetch: git fetch https://git.openjdk.org/jfx.git pull/1600/head:pull/1600
PR: https://git.openjdk.org/jfx/pull/1600
More information about the openjfx-dev
mailing list