RFR: 8301121: RichTextArea Control (Incubator) [v18]
Andy Goryachev
angorya at openjdk.org
Wed Oct 16 18:20:20 UTC 2024
On Fri, 4 Oct 2024 07:48:50 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:
>>> I observed an NPE with RichTextAreaDemoApp:
>>
>> I can't reproduce this...
>>
>> Are you on mac or windows? Are you testing the latest code (can you tell me the git commit hash?)
>> Also, could you take a screenshot when this happens, I'd like to see the settings on the right pane.
>
>> Are you on mac or windows? Are you testing the latest code (can you tell me the git commit hash?) Also, could you take a screenshot when this happens, I'd like to see the settings on the right pane.
>
> Tested it on Mac by fetching this PR using the command:
> `git fetch origin pull/1524/head:1524`
> HEAD commit: de3947b9f72e934acb2de4247cb851f40d7017e1 (HEAD -> 1524)
> Attaching a video :
>
> https://github.com/user-attachments/assets/65f2b5fd-4638-4f00-996a-02d1cf851969
Hello @arapte @aghaisas @lukostyra @azuev-java
could I ask you to review parts of the code, as follows (arbitrarily divided, please let me know if you want something else please):
**jfx.incubator.input**
com.sun.jfx.incubator.scene.control.input - 4 @arapte
jfx.incubator.scene.control.input - 8 @arapte
**jfx.incubator.richtext**
com.sun.jfx.incubator.scene.control.richtext - 35 @aghaisas
com.sun.jfx.incubator.scene.control.richtext.rtf - 7 @arapte
com.sun.jfx.incubator.scene.control.richtext.rtf.charsets - 5 @arapte
com.sun.jfx.incubator.scene.control.richtext.util - 5 @arapte
jfx.incubator.scene.control.richtext - 14 @lukostyra
jfx.incubator.scene.control.richtext.model - 20 @azuev-java
jfx.incubator.scene.control.richtext.skin - 4 @lukostyra
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1524#issuecomment-2417582557
More information about the openjfx-dev
mailing list