RFR: 8336031: Create implementation of NSAccessibilityStaticText protocol [v4]

Andy Goryachev angorya at openjdk.org
Wed Oct 16 19:08:19 UTC 2024


On Wed, 16 Oct 2024 10:10:04 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Initial implementation of the protocol.
>
> Alexander Zuev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8336031
>  - Merge pull request #10 from openjdk/master
>    
>    Merge
>  - Removing methods that supposed to generate attributed strings. String attributes are not available for the static text elements and cause exceptions to be thrown when requested.
>  - Add comment about AccessibleRole enuM
>  - 8336031: Create implementation of NSAccessibilityStaticText protocol
>    
>    Initial implementation of the protocol.

looks good, tested with the monkey tester on macOS 14.6.1 M1
I don't see the exception or stderr anymore.

This output is seen (as expected):

WARNING: A native method in com.sun.webkit.WebPage has been bound
WARNING: com.sun.webkit.WebPage::twkInitWebCore is declared in module javafx.web (file:/Users/angorya/Projects/jfx-1/jfx/rt/modules/javafx.web/bin/)
WARNING: Use --enable-native-access=javafx.web to avoid a warning for native methods declared in this module
WARNING: Restricted methods will be blocked in a future release unless native access is enabled

-------------

Marked as reviewed by angorya (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1507#pullrequestreview-2373434942


More information about the openjfx-dev mailing list