RFR: 8329098: Support "@1x" image naming convention as fallback [v2]
Lukasz Kostyra
lkostyra at openjdk.org
Fri Oct 18 14:57:06 UTC 2024
On Fri, 18 Oct 2024 14:19:12 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:
>> That is technically solved by re-calling `createInputStream(input)` like @mstr2 suggested to get a correct exception with valid message, so I will go with that approach.
>
> This is a bit minor, but what do you think about storing the previous exception in L385, and then re-throwing it? This is most likely exceedingly rare, but it might be possible that the reason why the previous call to `createInputStream` failed was only transient, we're not 100% sure that we can reproduce the exception by attempting it again.
This would technically create an ambiguity in the call stack (I checked and it points at in this case L385 instead of where the (re)throw actually happened) but if it's not a problem I can change it.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1598#discussion_r1806640811
More information about the openjfx-dev
mailing list