RFR: 8329098: Support "@1x" image naming convention as fallback [v2]

[John Hendrikx]

On Fri, 18 Oct 2024 15:09:27 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> This would technically create an ambiguity in the call stack (I checked and it points at in this case L385 instead of where the (re)throw actually happened) but if it's not a problem I can change it.
>
> I would think that this is acceptable, since that's the exception message that we expect to see (if the `@1x` version also can't be found).

I think the call stack being different is fine; call stacks are there for developers to debug code, and the users that are seeing these will not be debugging that particular code so the callstack being slightly off at the deepest level is fine.  Altenatively, you could still consider adding the `@1x` exception as a supressed exception to the first one (with Exception#addSuppressed`) but I wouldn't bother for this case.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1598#discussion_r1807390836