RFR: 8329098: Support "@1x" image naming convention as fallback [v4]

John Hendrikx jhendrikx at openjdk.org
Mon Oct 21 19:24:43 UTC 2024


On Mon, 21 Oct 2024 11:28:23 GMT, Lukasz Kostyra <lkostyra at openjdk.org> wrote:

>> This PR adds a title-mentioned fallback to `ImageStorage.java` and a test for that specific scenario.
>> 
>> In `ImageStorage.loadAll()` we still prefer the Image path that was provided by the user, but if it is missing we will now try to add a `@1x` suffix to Image name and give it one last try.
>> 
>> Added test includes a binary file `checkers at 1x.png`. This was added to differentiate it from the collection of `checker.png` files and their higher scale variants, but it is a direct copy of already existing `checker.png` test resource, just with a different name and suffix. Test should fail without a change in `ImageStorage.java` and pass with it.
>
> Lukasz Kostyra has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Store and rethrow exception from main createInputStream()

Marked as reviewed by jhendrikx (Reviewer).

-------------

PR Review: https://git.openjdk.org/jfx/pull/1598#pullrequestreview-2383127362


More information about the openjfx-dev mailing list